x86/efi: Remove the unused efi_get_time() function (b684e9bc) · Commits · 戴 / test

Nothing calls the efi_get_time() function on x86, but it does suffer from the 32-bit time_t overflow in 2038. This removes the function, we can always put it back in case we need it later. Signed-off-by:

Arnd Bergmann <arnd@arndb.de> Signed-off-by:

Matt Fleming <matt@codeblueprint.co.uk> Acked-by:

Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: linux-efi@vger.kernel.org Link: http://lkml.kernel.org/r/1466839230-12781-8-git-send-email-matt@codeblueprint.co.uk Signed-off-by:

Ingo Molnar <mingo@kernel.org>

arch/x86/platform/efi/efi.c

+0 −15

Original line number	Diff line number	Diff line
		@@ -98,21 +98,6 @@ static efi_status_t __init phys_efi_set_virtual_address_map(
		return status;
		}

		void efi_get_time(struct timespec *now)
		{
		efi_status_t status;
		efi_time_t eft;
		efi_time_cap_t cap;

		status = efi.get_time(&eft, &cap);
		if (status != EFI_SUCCESS)
		pr_err("Oops: efitime: can't read time!\n");

		now->tv_sec = mktime(eft.year, eft.month, eft.day, eft.hour,
		eft.minute, eft.second);
		now->tv_nsec = 0;
		}

		void __init efi_find_mirror(void)
		{
		efi_memory_desc_t *md;

include/linux/efi.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -990,7 +990,6 @@ extern u64 efi_mem_desc_end(efi_memory_desc_t *md);
		extern int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md);
		extern void efi_initialize_iomem_resources(struct resource *code_resource,
		struct resource data_resource, struct resource bss_resource);
		extern void efi_get_time(struct timespec *now);
		extern void efi_reserve_boot_services(void);
		extern int efi_get_fdt_params(struct efi_fdt_params *params);
		extern struct kobject *efi_kobj;

Admin message