mfd: Add missing max8997 static storage class specifier (b673e24c) · Commits · 戴 / test

Fixes the following sparse warnings: drivers/mfd/max8997.c:209:4: warning: symbol 'max8997_dumpaddr_pmic' was not declared. Should it be static? drivers/mfd/max8997.c:334:4: warning: symbol 'max8997_dumpaddr_muic' was not declared. Should it be static? drivers/mfd/max8997.c:344:4: warning: symbol 'max8997_dumpaddr_haptic' was not declared. Should it be static? drivers/mfd/max8997.c:426:25: warning: symbol 'max8997_pm' was not declared. Should it be static? Signed-off-by:

Sachin Kamat <sachin.kamat@linaro.org> Acked-by:

MyungJoo Ham <myungjoo.ham@samsung.com> Signed-off-by:

Samuel Ortiz <sameo@linux.intel.com>

drivers/mfd/max8997.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -206,7 +206,7 @@ static const struct i2c_device_id max8997_i2c_id[] = {
		};
		MODULE_DEVICE_TABLE(i2c, max8998_i2c_id);

		u8 max8997_dumpaddr_pmic[] = {
		static u8 max8997_dumpaddr_pmic[] = {
		MAX8997_REG_INT1MSK,
		MAX8997_REG_INT2MSK,
		MAX8997_REG_INT3MSK,
		@@ -331,7 +331,7 @@ u8 max8997_dumpaddr_pmic[] = {
		MAX8997_REG_DVSOKTIMER5,
		};

		u8 max8997_dumpaddr_muic[] = {
		static u8 max8997_dumpaddr_muic[] = {
		MAX8997_MUIC_REG_INTMASK1,
		MAX8997_MUIC_REG_INTMASK2,
		MAX8997_MUIC_REG_INTMASK3,
		@@ -341,7 +341,7 @@ u8 max8997_dumpaddr_muic[] = {
		MAX8997_MUIC_REG_CONTROL3,
		};

		u8 max8997_dumpaddr_haptic[] = {
		static u8 max8997_dumpaddr_haptic[] = {
		MAX8997_HAPTIC_REG_CONF1,
		MAX8997_HAPTIC_REG_CONF2,
		MAX8997_HAPTIC_REG_DRVCONF,
		@@ -423,7 +423,7 @@ static int max8997_resume(struct device *dev)
		return max8997_irq_resume(max8997);
		}

		const struct dev_pm_ops max8997_pm = {
		static const struct dev_pm_ops max8997_pm = {
		.suspend = max8997_suspend,
		.resume = max8997_resume,
		.freeze = max8997_freeze,

Admin message