Commit b658b8f5 authored Jun 17, 2014 by Dan Williams Committed by Greg Kroah-Hartman Jun 17, 2014

usb: improve "not suspended yet" message in hub_suspend()

Reading through a recent bug report [1], Alan notes:

  "Dan, the warning message in hub_suspend() should mention that the
   child device isn't suspended yet."

...update the warning from:

  "usb usb3-port4: not suspended yet"

...to:

   "usb usb3-port4: device 3-4: not suspended yet"

[1]: http://marc.info/?l=linux-usb&m=140290586301336&w=2



Reported-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent be3de321

drivers/usb/core/hub.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -3458,7 +3458,8 @@ static int hub_suspend(struct usb_interface *intf, pm_message_t msg)
		struct usb_device *udev = port_dev->child;

		if (udev && udev->can_submit) {
		dev_warn(&port_dev->dev, "not suspended yet\n");
		dev_warn(&port_dev->dev, "device %s not suspended yet\n",
		dev_name(&udev->dev));
		if (PMSG_IS_AUTO(msg))
		return -EBUSY;
		}

Admin message