Commit b6576210 authored Aug 09, 2020 by Christophe JAILLET Committed by Wim Van Sebroeck Oct 14, 2020

watchdog: pcwd_usb: Avoid GFP_ATOMIC where it is not needed



There is no need to use GFP_ATOMIC here. It is a probe function, no
spinlock is taken and GFP_KERNEL is used just before and just after this
'usb_alloc_coherent()' call.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20200809071912.742836-1-christophe.jaillet@wanadoo.fr


Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>

parent 4b2e7f99

drivers/watchdog/pcwd_usb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -656,7 +656,7 @@ static int usb_pcwd_probe(struct usb_interface *interface,

		/* set up the memory buffer's */
		usb_pcwd->intr_buffer = usb_alloc_coherent(udev, usb_pcwd->intr_size,
		GFP_ATOMIC, &usb_pcwd->intr_dma);
		GFP_KERNEL, &usb_pcwd->intr_dma);
		if (!usb_pcwd->intr_buffer) {
		pr_err("Out of memory\n");
		goto error;

Admin message