Commit b646293e authored Oct 04, 2019 by Chris Lew Committed by Bjorn Andersson Oct 16, 2019

rpmsg: glink: Put an extra reference during cleanup



In a remote processor crash scenario, there is no guarantee the remote
processor sent close requests before it went into a bad state. Remove
the reference that is normally handled by the close command in the
so channel resources can be released.

Fixes: b4f8e52b ("rpmsg: Introduce Qualcomm RPM glink driver")
Cc: stable@vger.kernel.org
Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Chris Lew <clew@codeaurora.org>
Reported-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

parent ac74ea01

drivers/rpmsg/qcom_glink_native.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1641,6 +1641,10 @@ void qcom_glink_native_remove(struct qcom_glink *glink)
		idr_for_each_entry(&glink->lcids, channel, cid)
		kref_put(&channel->refcount, qcom_glink_channel_release);

		/* Release any defunct local channels, waiting for close-req */
		idr_for_each_entry(&glink->rcids, channel, cid)
		kref_put(&channel->refcount, qcom_glink_channel_release);

		idr_destroy(&glink->lcids);
		idr_destroy(&glink->rcids);
		spin_unlock_irqrestore(&glink->idr_lock, flags);

Admin message