Commit b63d7c2e authored by NeilBrown's avatar NeilBrown
Browse files

md/bitmap: clean up plugging calls. 



1/ use md_unplug in bitmap.c as we will soon be using bitmaps under
  arrays with no queue attached.

2/ Don't bother plugging the queue when we set a bit in the bitmap.
   The reason for this was to encourage as many bits as possible to
   get set before we unplug and write stuff out.
   However every personality already plugs the queue after
   bitmap_startwrite either directly (raid1/raid10) or be setting
   STRIPE_BIT_DELAY which causes the queue to be plugged later
   (raid5).

Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent 5ff5afff

drivers/md/bitmap.c

+1 −2
Original line number Diff line number Diff line
@@ -1296,7 +1296,7 @@ int bitmap_startwrite(struct bitmap *bitmap, sector_t offset, unsigned long sect 
			prepare_to_wait(&bitmap->overflow_wait, &__wait,

					TASK_UNINTERRUPTIBLE);

			spin_unlock_irq(&bitmap->lock);

			blk_unplug(bitmap->mddev->queue);

			md_unplug(bitmap->mddev);

			schedule();

			finish_wait(&bitmap->overflow_wait, &__wait);

			continue;
@@ -1306,7 +1306,6 @@ int bitmap_startwrite(struct bitmap *bitmap, sector_t offset, unsigned long sect 
		case 0:

			bitmap_file_set_bit(bitmap, offset);

			bitmap_count_page(bitmap, offset, 1);

			blk_plug_device_unlocked(bitmap->mddev->queue);

			/* fall through */

		case 1:

			*bmc = 2;

drivers/md/md.c

+1 −1
Original line number Diff line number Diff line
@@ -6627,7 +6627,7 @@ int md_allow_write(mddev_t *mddev) 
}

EXPORT_SYMBOL_GPL(md_allow_write);



static void md_unplug(mddev_t *mddev)

void md_unplug(mddev_t *mddev)

{

	if (mddev->queue)

		blk_unplug(mddev->queue);

drivers/md/md.h

+1 −0
Original line number Diff line number Diff line
@@ -509,6 +509,7 @@ extern int md_integrity_register(mddev_t *mddev); 
extern void md_integrity_add_rdev(mdk_rdev_t *rdev, mddev_t *mddev);

extern int strict_strtoul_scaled(const char *cp, unsigned long *res, int scale);

extern void restore_bitmap_write_access(struct file *file);

extern void md_unplug(mddev_t *mddev);



extern void mddev_init(mddev_t *mddev);

extern int md_run(mddev_t *mddev);

CRA Git | Maintained and supported by SUSTech CRA and CCSE