soundwire: stream: remove redundant pr_err traces (b6371248) · Commits · 戴 / test

Only keep pr_err to flag critical configuration errors that will typically only happen during system integration. For errors on prepare/deprepare/enable/disable, the caller can do a much better job with more information on the DAI and device that caused the issue. Suggested-by:

Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by:

Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20200108175438.13121-2-pierre-louis.bossart@linux.intel.com Signed-off-by:

Vinod Koul <vkoul@kernel.org>

drivers/soundwire/stream.c

+0 −8

Original line number	Diff line number	Diff line
		@@ -1554,8 +1554,6 @@ int sdw_prepare_stream(struct sdw_stream_runtime *stream)
		sdw_acquire_bus_lock(stream);

		ret = _sdw_prepare_stream(stream);
		if (ret < 0)
		pr_err("Prepare for stream:%s failed: %d\n", stream->name, ret);

		sdw_release_bus_lock(stream);
		return ret;
		@@ -1622,8 +1620,6 @@ int sdw_enable_stream(struct sdw_stream_runtime *stream)
		sdw_acquire_bus_lock(stream);

		ret = _sdw_enable_stream(stream);
		if (ret < 0)
		pr_err("Enable for stream:%s failed: %d\n", stream->name, ret);

		sdw_release_bus_lock(stream);
		return ret;
		@@ -1698,8 +1694,6 @@ int sdw_disable_stream(struct sdw_stream_runtime *stream)
		sdw_acquire_bus_lock(stream);

		ret = _sdw_disable_stream(stream);
		if (ret < 0)
		pr_err("Disable for stream:%s failed: %d\n", stream->name, ret);

		sdw_release_bus_lock(stream);
		return ret;
		@@ -1756,8 +1750,6 @@ int sdw_deprepare_stream(struct sdw_stream_runtime *stream)

		sdw_acquire_bus_lock(stream);
		ret = _sdw_deprepare_stream(stream);
		if (ret < 0)
		pr_err("De-prepare for stream:%d failed: %d\n", ret, ret);

		sdw_release_bus_lock(stream);
		return ret;

Admin message