Commit b6355fb3 authored Dec 20, 2016 by Sudip Mukherjee Committed by Samuel Ortiz Apr 02, 2017

nfc: fdp: fix NULL pointer dereference

We are checking phy after dereferencing it. We can print the debug
information after checking it. If phy is NULL then we will get a good
stack trace to tell us that we are in this irq handler.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>

parent ce69b95c

drivers/nfc/fdp/i2c.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -210,14 +210,14 @@ static irqreturn_t fdp_nci_i2c_irq_thread_fn(int irq, void *phy_id)
		struct sk_buff *skb;
		int r;

		client = phy->i2c_dev;
		dev_dbg(&client->dev, "%s\n", __func__);

		if (!phy \|\| irq != phy->i2c_dev->irq) {
		WARN_ON_ONCE(1);
		return IRQ_NONE;
		}

		client = phy->i2c_dev;
		dev_dbg(&client->dev, "%s\n", __func__);

		r = fdp_nci_i2c_read(phy, &skb);

		if (r == -EREMOTEIO)