ACPI / EC: Drop suspend and resume routines (b63559f5) · Commits · 戴 / test

The suspend and resume routines provided by the EC driver are not really necessary, because the handler of the GPE disabled by them is not going to be executed after suspend_device_irqs() and before resume_device_irqs() anyway. Signed-off-by:

Rafael J. Wysocki <rjw@sisk.pl> Signed-off-by:

Len Brown <len.brown@intel.com>

drivers/acpi/ec.c

+0 −18

Original line number	Diff line number	Diff line
		@@ -1088,22 +1088,6 @@ error:
		return -ENODEV;
		}

		static int acpi_ec_suspend(struct acpi_device *device, pm_message_t state)
		{
		struct acpi_ec *ec = acpi_driver_data(device);
		/* Stop using the GPE, but keep it reference counted. */
		acpi_set_gpe(NULL, ec->gpe, ACPI_GPE_DISABLE);
		return 0;
		}

		static int acpi_ec_resume(struct acpi_device *device)
		{
		struct acpi_ec *ec = acpi_driver_data(device);
		/* Enable the GPE again, but don't reference count it once more. */
		acpi_set_gpe(NULL, ec->gpe, ACPI_GPE_ENABLE);
		return 0;
		}

		static struct acpi_driver acpi_ec_driver = {
		.name = "ec",
		.class = ACPI_EC_CLASS,
		@@ -1111,8 +1095,6 @@ static struct acpi_driver acpi_ec_driver = {
		.ops = {
		.add = acpi_ec_add,
		.remove = acpi_ec_remove,
		.suspend = acpi_ec_suspend,
		.resume = acpi_ec_resume,
		},
		};

Admin message