dma/ep93xx_dma: fix initialization of M2M control register (b62cfc5e) · Commits · 戴 / test

Setting the flags in case of IDE didn't have any effect since the control register is overwritten few lines below. So move these to be after the control register is initialized. Signed-off-by:

Rafal Prylowski <prylowski@metasoft.pl> Signed-off-by:

Mika Westerberg <mika.westerberg@iki.fi> Acked-by:

H Hartley Sweeten <hsweeten@visionengravers.com> Signed-off-by:

Vinod Koul <vinod.koul@linux.intel.com>

drivers/dma/ep93xx_dma.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -459,10 +459,6 @@ static int m2m_hw_setup(struct ep93xx_dma_chan *edmac)
		* This IDE part is totally untested. Values below are taken
		* from the EP93xx Users's Guide and might not be correct.
		*/
		control \|= M2M_CONTROL_NO_HDSK;
		control \|= M2M_CONTROL_RSS_IDE;
		control \|= M2M_CONTROL_PW_16;

		if (data->direction == DMA_MEM_TO_DEV) {
		/* Worst case from the UG */
		control = (3 << M2M_CONTROL_PWSC_SHIFT);
		@@ -473,6 +469,10 @@ static int m2m_hw_setup(struct ep93xx_dma_chan *edmac)
		control \|= M2M_CONTROL_SAH;
		control \|= M2M_CONTROL_TM_RX;
		}

		control \|= M2M_CONTROL_NO_HDSK;
		control \|= M2M_CONTROL_RSS_IDE;
		control \|= M2M_CONTROL_PW_16;
		break;

		default:

Admin message