Unverified Commit b6198097 authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Mark Brown
Browse files

ASoC: q6asm: add command opcode to timeout error report 



Make the error reporting more useful by adding opcode to it.
Without this its almost impossible to say which command actually
timed out.

Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20200707163641.17113-2-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent a5911ac5

sound/soc/qcom/qdsp6/q6asm.c

+2 −2
Original line number Diff line number Diff line
@@ -311,7 +311,7 @@ static int q6asm_apr_send_session_pkt(struct q6asm *a, struct audio_client *ac, 
					5 * HZ);



	if (!rc) {

		dev_err(a->dev, "CMD timeout\n");

		dev_err(a->dev, "CMD %x timeout\n", hdr->opcode);

		rc = -ETIMEDOUT;

	} else if (ac->result.status > 0) {

		dev_err(a->dev, "DSP returned error[%x]\n",
@@ -891,7 +891,7 @@ static int q6asm_ac_send_cmd_sync(struct audio_client *ac, struct apr_pkt *pkt) 
	rc = wait_event_timeout(ac->cmd_wait,

				(ac->result.opcode == hdr->opcode), 5 * HZ);

	if (!rc) {

		dev_err(ac->dev, "CMD timeout\n");

		dev_err(ac->dev, "CMD %x timeout\n", hdr->opcode);

		rc =  -ETIMEDOUT;

		goto err;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE