Commit b618c327 authored Nov 16, 2020 by kernel test robot Committed by Jakub Kicinski Nov 17, 2020

net: phy: mscc: fix excluded_middle.cocci warnings



Condition !A || A && B is equivalent to !A || B.

Generated by: scripts/coccinelle/misc/excluded_middle.cocci

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
Reviewed-by: Antoine Tenart <atenart@kernel.org>
Link: https://lore.kernel.org/r/alpine.DEB.2.22.394.2011161633240.2682@hadrien


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent f85cd064

drivers/net/phy/mscc/mscc_ptp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -136,7 +136,7 @@ static void vsc85xx_ts_write_csr(struct phy_device *phydev, enum ts_blk blk,

		phy_ts_base_write(phydev, MSCC_EXT_PAGE_ACCESS, MSCC_PHY_PAGE_1588);

		if (!cond \|\| (cond && upper))
		if (!cond \|\| upper)
		phy_ts_base_write(phydev, MSCC_PHY_TS_CSR_DATA_MSB, upper);

		phy_ts_base_write(phydev, MSCC_PHY_TS_CSR_DATA_LSB, lower);

Admin message