Commit b610c04c authored Jul 30, 2012 by Will Deacon Committed by Linus Torvalds Jul 30, 2012

ipc: allow compat IPC version field parsing if !ARCH_WANT_OLD_COMPAT_IPC



Commit 48b25c43 ("ipc: provide generic compat versions of IPC
syscalls") added a new ARCH_WANT_OLD_COMPAT_IPC config option for
architectures to select if their compat target requires the old IPC
syscall interface.

For architectures (such as AArch64) that do not require the internal
calling conventions provided by this option, but have a compat target
where the C library passes the IPC_64 flag explicitly,
compat_ipc_parse_version no longer strips out the flag before calling
the native system call implementation, resulting in unknown SHM/IPC
commands and -EINVAL being returned to userspace.

This patch separates the selection of the internal calling conventions
for the IPC syscalls from the version parsing, allowing architectures to
select __ARCH_WANT_COMPAT_IPC_PARSE_VERSION if they want to use version
parsing whilst retaining the newer syscall calling conventions.

Acked-by: Chris Metcalf <cmetcalf@tilera.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 079a96ae

include/linux/compat.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -256,6 +256,7 @@ compat_sys_get_robust_list(int pid, compat_uptr_t __user *head_ptr,
		compat_size_t __user *len_ptr);

		#ifdef CONFIG_ARCH_WANT_OLD_COMPAT_IPC
		#define __ARCH_WANT_COMPAT_IPC_PARSE_VERSION
		long compat_sys_semctl(int first, int second, int third, void __user *uptr);
		long compat_sys_msgsnd(int first, int second, int third, void __user *uptr);
		long compat_sys_msgrcv(int first, int second, int msgtyp, int third,

ipc/compat.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -118,7 +118,7 @@ extern int sem_ctls[];

		static inline int compat_ipc_parse_version(int *cmd)
		{
		#ifdef CONFIG_ARCH_WANT_OLD_COMPAT_IPC
		#ifdef __ARCH_WANT_COMPAT_IPC_PARSE_VERSION
		int version = *cmd & IPC_64;

		/* this is tricky: architectures that have support for the old

Admin message