Commit b60b6592 authored May 11, 2010 by stephen hemminger Committed by David S. Miller May 17, 2010

net sched: cleanup and rate limit warning



If the user has a bad classification configuration, and gets a packet
that goes through too many steps. Chances are more packets will arrive,
and the message spew will overrun syslog because it is not rate limited.
And because it is not tagged with appropriate priority it can't not be screened.

Added the qdisc to the message to try and give some more context when
the message does arrive.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Jamal Hadi Salim <hadi@cyberus.ca>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 207024b9

net/sched/sch_api.c

+6 −3

Original line number	Diff line number	Diff line
		@@ -1637,8 +1637,11 @@ reclassify:
		tp = otp;

		if (verd++ >= MAX_REC_LOOP) {
		printk("rule prio %u protocol %02x reclassify loop, "
		"packet dropped\n",
		if (net_ratelimit())
		printk(KERN_NOTICE
		"%s: packet reclassify loop"
		" rule prio %u protocol %02x\n",
		tp->q->ops->id,
		tp->prio & 0xffff, ntohs(tp->protocol));
		return TC_ACT_SHOT;
		}

Admin message