Commit b60a7738 authored Jun 26, 2019 by Florian Westphal Committed by David S. Miller Jun 29, 2019

net: make skb_dst_force return true when dst is refcounted



netfilter did not expect that skb_dst_force() can cause skb to lose its
dst entry.

I got a bug report with a skb->dst NULL dereference in netfilter
output path.  The backtrace contains nf_reinject(), so the dst might have
been cleared when skb got queued to userspace.

Other users were fixed via
if (skb_dst(skb)) {
	skb_dst_force(skb);
	if (!skb_dst(skb))
		goto handle_err;
}

But I think its preferable to make the 'dst might be cleared' part
of the function explicit.

In netfilter case, skb with a null dst is expected when queueing in
prerouting hook, so drop skb for the other hooks.

v2:
 v1 of this patch returned true in case skb had no dst entry.
 Eric said:
   Say if we have two skb_dst_force() calls for some reason
   on the same skb, only the first one will return false.

 This now returns false even when skb had no dst, as per Erics
 suggestion, so callers might need to check skb_dst() first before
 skb_dst_force().

Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9b6c0887

include/net/dst.h

+4 −1

Original line number	Diff line number	Diff line
		@@ -302,8 +302,9 @@ static inline bool dst_hold_safe(struct dst_entry *dst)
		* @skb: buffer
		*
		* If dst is not yet refcounted and not destroyed, grab a ref on it.
		* Returns true if dst is refcounted.
		*/
		static inline void skb_dst_force(struct sk_buff *skb)
		static inline bool skb_dst_force(struct sk_buff *skb)
		{
		if (skb_dst_is_noref(skb)) {
		struct dst_entry *dst = skb_dst(skb);
		@@ -314,6 +315,8 @@ static inline void skb_dst_force(struct sk_buff *skb)

		skb->_skb_refdst = (unsigned long)dst;
		}

		return skb->_skb_refdst != 0UL;
		}

net/netfilter/nf_queue.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -190,6 +190,11 @@ static int __nf_queue(struct sk_buff skb, const struct nf_hook_state state,
		goto err;
		}

		if (!skb_dst_force(skb) && state->hook != NF_INET_PRE_ROUTING) {
		status = -ENETDOWN;
		goto err;
		}

		*entry = (struct nf_queue_entry) {
		.skb = skb,
		.state = *state,
		@@ -198,7 +203,6 @@ static int __nf_queue(struct sk_buff skb, const struct nf_hook_state state,
		};

		nf_queue_entry_get_refs(entry);
		skb_dst_force(skb);

		switch (entry->state.pf) {
		case AF_INET:

Admin message