Commit b5fd2e00 authored Dec 03, 2018 by Dan Williams

acpi/nfit: Fix user-initiated ARS to be "ARS-long" rather than "ARS-short"



A "short" ARS (address range scrub) instructs the platform firmware to
return known errors. In contrast, a "long" ARS instructs platform
firmware to arrange every data address on the DIMM to be read / checked
for poisoned data.

The conversion of the flags in commit d3abaf43 "acpi, nfit: Fix
Address Range Scrub completion tracking", changed the meaning of passing
'0' to acpi_nfit_ars_rescan(). Previously '0' meant "not short", now '0'
is ARS_REQ_SHORT. Pass ARS_REQ_LONG to restore the expected scrub-type
behavior of user-initiated ARS sessions.

Fixes: d3abaf43 ("acpi, nfit: Fix Address Range Scrub completion tracking")
Reported-by: Jacek Zloch <jacek.zloch@intel.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

parent ae86cbfe

drivers/acpi/nfit/core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1308,7 +1308,7 @@ static ssize_t scrub_store(struct device *dev,
		if (nd_desc) {
		struct acpi_nfit_desc *acpi_desc = to_acpi_desc(nd_desc);

		rc = acpi_nfit_ars_rescan(acpi_desc, 0);
		rc = acpi_nfit_ars_rescan(acpi_desc, ARS_REQ_LONG);
		}
		device_unlock(dev);
		if (rc)

Admin message