Commit b5f83e9b authored May 28, 2013 by Markus Pargmann Committed by Shawn Guo Jun 03, 2013

ARM: mxs: icoll: Fix interrupts gpio bank 0



The mxs interrupt controller does not support polling for interrupts,
but the driver still does it, which is a relict from
pre-MULTI_IRQ_HANDLER times.

The existing code assumes that 0x7f means no interrupt, but this value
is an actually valid irq number, namely gpio bank 0's irq. This results
in the driver not detecting when irq 0x7f is active which makes the
machine effectively dead lock.

This patch removes the interrupt poll loop and allows usage of gpio0
interrupt without an infinite loop.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
Cc: stable@vger.kernel.org
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>

parent f722406f

drivers/irqchip/irq-mxs.c

+4 −10

Original line number	Diff line number	Diff line
		@@ -76,16 +76,10 @@ asmlinkage void __exception_irq_entry icoll_handle_irq(struct pt_regs *regs)
		{
		u32 irqnr;

		do {
		irqnr = __raw_readl(icoll_base + HW_ICOLL_STAT_OFFSET);
		if (irqnr != 0x7f) {
		__raw_writel(irqnr, icoll_base + HW_ICOLL_VECTOR);
		irqnr = irq_find_mapping(icoll_domain, irqnr);
		handle_IRQ(irqnr, regs);
		continue;
		}
		break;
		} while (1);
		}

		static int icoll_irq_domain_map(struct irq_domain *d, unsigned int virq,

Admin message