Commit b5b60fda authored Dec 18, 2009 by Arnaldo Carvalho de Melo Committed by Ingo Molnar Dec 18, 2009

perf session: Make events_stats u64 to avoid overflow on 32-bit arches



Pekka Enberg reported weird percentages in perf report. It
turns out we are overflowing a 32-bit variables in struct
events_stats on 32-bit architectures.

Before:

 [acme@ana linux-2.6-tip]$ perf report -i pekka.perf.data 2> /dev/null | head -10
   281.96%       Xorg                        b710a561  [.] 0x000000b710a561
   140.15%       Xorg  [kernel]                        [k] __initramfs_end
    51.56%   metacity  libgobject-2.0.so.0.2000.1      [.] 0x00000000026e46
    35.12%  evolution  libcairo.so.2.10800.6           [.] 0x000000000203bd
    33.84%   metacity  libpthread-2.9.so               [.] 0x00000000007a3d

After:

 [acme@ana linux-2.6-tip]$ perf report -i pekka.perf.data 2> /dev/null | head -10
    30.04%       Xorg                       b710a561   [.] 0x000000b710a561
    14.93%       Xorg  [kernel]                        [k] __initramfs_end
     5.49%   metacity  libgobject-2.0.so.0.2000.1      [.] 0x00000000026e46
     3.74%  evolution  libcairo.so.2.10800.6           [.] 0x000000000203bd
     3.61%   metacity  libpthread-2.9.so               [.] 0x00000000007a3d

Reported-by: Pekka Enberg <penberg@cs.helsinki.fi>
Tested-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1261148583-20395-1-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 99e8c5a3

tools/perf/builtin-report.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -224,7 +224,7 @@ static int __cmd_report(void)

		perf_session__collapse_resort(session);
		perf_session__output_resort(session, session->events_stats.total);
		fprintf(stdout, "# Samples: %ld\n#\n", session->events_stats.total);
		fprintf(stdout, "# Samples: %Ld\n#\n", session->events_stats.total);
		perf_session__fprintf_hists(session, NULL, false, stdout);
		if (sort_order == default_sort_order &&
		parent_pattern == default_parent_pattern)

tools/perf/util/event.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -95,8 +95,8 @@ typedef union event_union {
		} event_t;

		struct events_stats {
		unsigned long total;
		unsigned long lost;
		u64 total;
		u64 lost;
		};

		void event__print_totals(void);

Admin message