Commit b5b0180c authored May 27, 2020 by Peter Ujfalusi Committed by Vinod Koul Jun 16, 2020

dmaengine: ti: k3-udma: Fix the running channel handling in alloc_chan_resources



In the unlikely case when the channel is running (RT enabled) during
alloc_chan_resources then we should use udma_reset_chan() and not
udma_stop() as the later is trying to initiate a teardown on the channel,
which is not valid at this point.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/20200527070612.636-3-peter.ujfalusi@ti.com


Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 5a9377cc

drivers/dma/ti/k3-udma.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1848,7 +1848,7 @@ static int udma_alloc_chan_resources(struct dma_chan *chan)

		if (udma_is_chan_running(uc)) {
		dev_warn(ud->dev, "chan%d: is running!\n", uc->id);
		udma_stop(uc);
		udma_reset_chan(uc, false);
		if (udma_is_chan_running(uc)) {
		dev_err(ud->dev, "chan%d: won't stop!\n", uc->id);
		ret = -EBUSY;

Admin message