Commit b5a80252 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: legousbtower: drop redundant open_count check



Drop redundant open_count check in release; the open count is used as a
flag and is only set to 0 or 1.

Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20191105084152.16322-5-johan@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 30da837a
Loading
Loading
Loading
Loading
+0 −8
Original line number Diff line number Diff line
@@ -421,13 +421,6 @@ static int tower_release (struct inode *inode, struct file *file)

	mutex_lock(&dev->lock);

	if (dev->open_count != 1) {
		dev_dbg(&dev->udev->dev, "%s: device not opened exactly once\n",
			__func__);
		retval = -ENODEV;
		goto unlock_exit;
	}

	if (dev->disconnected) {
		/* the device was unplugged before the file was released */

@@ -444,7 +437,6 @@ static int tower_release (struct inode *inode, struct file *file)
	tower_abort_transfers (dev);
	dev->open_count = 0;

unlock_exit:
	mutex_unlock(&dev->lock);
exit:
	return retval;