Commit b59aeb1a authored Jul 17, 2020 by Yoshihiro Shimoda Committed by Vinod Koul Jul 20, 2020

phy: renesas: rcar-gen3-usb2: exit if request_irq() failed



To avoid unexpected behaviors, it's better to exit if request_irq()
failed.

Suggested-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Link: https://lore.kernel.org/r/1594986297-12434-3-git-send-email-yoshihiro.shimoda.uh@renesas.com


Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 08b0ad37

drivers/phy/renesas/phy-rcar-gen3-usb2.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -419,8 +419,10 @@ static int rcar_gen3_phy_usb2_init(struct phy *p)
		INIT_WORK(&channel->work, rcar_gen3_phy_usb2_work);
		ret = request_irq(channel->irq, rcar_gen3_phy_usb2_irq,
		IRQF_SHARED, dev_name(channel->dev), channel);
		if (ret < 0)
		if (ret < 0) {
		dev_err(channel->dev, "No irq handler (%d)\n", channel->irq);
		return ret;
		}
		}

		/* Initialize USB2 part */

Admin message