SUNRPC: Don't confuse ENOBUFS with a write_space issue (b5872f0c) · Commits · 戴 / test

ENOBUFS means that memory allocations are failing due to an actual low memory situation. It should not be confused with being out of socket buffer space. Handle the problem by just punting to the delay in call_status. Reported-by:

Neil Brown <neilb@suse.com> Signed-off-by:

Trond Myklebust <trond.myklebust@primarydata.com>

net/sunrpc/xprtsock.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -539,6 +539,7 @@ static int xs_local_send_request(struct rpc_task *task)

		switch (status) {
		case -ENOBUFS:
		break;
		case -EAGAIN:
		status = xs_nospace(task);
		break;
		@@ -692,7 +693,6 @@ static int xs_tcp_send_request(struct rpc_task *task)
		status = -ENOTCONN;
		/* Should we call xs_close() here? */
		break;
		case -ENOBUFS:
		case -EAGAIN:
		status = xs_nospace(task);
		break;
		@@ -703,6 +703,7 @@ static int xs_tcp_send_request(struct rpc_task *task)
		case -ECONNREFUSED:
		case -ENOTCONN:
		case -EADDRINUSE:
		case -ENOBUFS:
		case -EPIPE:
		clear_bit(SOCK_ASYNC_NOSPACE, &transport->sock->flags);
		}

Admin message