Commit b569e924 authored Jan 08, 2010 by Lennert Buytenhek Committed by John W. Linville Jan 12, 2010

mwl8k: undo transmit queue 0/1 swapping in mwl8k_cmd_set_edca_params()



The comment and code in mwl8k_cmd_set_edca_params() suggest that the
mapping between SET_EDCA_PARAMS queue numbers and transmit rings isn't
actually 1:1, while tests show that the mapping is in fact 1:1.  So,
get rid of the transmit queue 0/1 swapping.

Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent c2c2b12a

drivers/net/wireless/mwl8k.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -2397,12 +2397,6 @@ mwl8k_cmd_set_edca_params(struct ieee80211_hw *hw, __u8 qnum,
		if (cmd == NULL)
		return -ENOMEM;

		/*
		* Queues 0 (BE) and 1 (BK) are swapped in hardware for
		* this call.
		*/
		qnum ^= !(qnum >> 1);

		cmd->header.code = cpu_to_le16(MWL8K_CMD_SET_EDCA_PARAMS);
		cmd->header.length = cpu_to_le16(sizeof(*cmd));
		cmd->action = cpu_to_le16(MWL8K_SET_EDCA_ALL);

Admin message