Commit b565a390 authored May 16, 2012 by K. Y. Srinivasan Committed by Jiri Kosina May 17, 2012

HID: hyperv: Set the hid drvdata correctly



Set the hid drvdata prior to invoking hid_add_device() as hid_add_device()
expects this state to be set. This bug was introduced in the recent hid
changes that were made in 07d9ab4f ("HID: hid-hyperv: Do not use
hid_parse_report() directly").

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 16b79bb8

drivers/hid/hid-hyperv.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -516,11 +516,12 @@ static int mousevsc_probe(struct hv_device *device,

		sprintf(hid_dev->name, "%s", "Microsoft Vmbus HID-compliant Mouse");

		hid_set_drvdata(hid_dev, device);

		ret = hid_add_device(hid_dev);
		if (ret)
		goto probe_err1;

		hid_set_drvdata(hid_dev, device);

		ret = hid_parse(hid_dev);
		if (ret) {

Admin message