Commit b561783c authored Mar 22, 2017 by Guilherme G. Piccoli Committed by Michael Ellerman Mar 28, 2017

powerpc/xmon: drop the nobt option from xmon plus minor fixes



The xmon parameter nobt was added long time ago, by commit 26c8af5f
("[POWERPC] print backtrace when entering xmon"). The problem that time
was that during a crash in a machine with USB keyboard, xmon wouldn't
respond to commands from the keyboard, so printing the backtrace wouldn't
be possible.

Idea then was to show automatically the backtrace on xmon crash for the
first time it's invoked (if it recovers, next time xmon won't show
backtrace automatically). The nobt parameter was added _only_ to prevent
this automatic trace show. Seems long time ago USB keyboards didn't work
that well!

We don't need this parameter anymore, the feature of auto showing the
backtrace is interesting (imagine a case of auto-reboot script),
so this patch extends the functionality, by always showing the backtrace
automatically when xmon is invoked; it removes the nobt parameter too.

Also, this patch fixes __initdata placement on xmon_early and replaces
__initcall() with modern device_initcall() on sysrq handler.

Signed-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent 3b5bf42b

arch/powerpc/xmon/xmon.c

+3 −10

Original line number	Diff line number	Diff line
		@@ -185,8 +185,6 @@ static void dump_tlb_44x(void);
		static void dump_tlb_book3e(void);
		#endif

		static int xmon_no_auto_backtrace;

		#ifdef CONFIG_PPC64
		#define REG "%.16lx"
		#else
		@@ -885,10 +883,7 @@ cmds(struct pt_regs *excp)
		last_cmd = NULL;
		xmon_regs = excp;

		if (!xmon_no_auto_backtrace) {
		xmon_no_auto_backtrace = 1;
		xmon_show_stack(excp->gpr[1], excp->link, excp->nip);
		}

		for(;;) {
		#ifdef CONFIG_SMP
		@@ -3318,10 +3313,10 @@ static int __init setup_xmon_sysrq(void)
		register_sysrq_key('x', &sysrq_xmon_op);
		return 0;
		}
		__initcall(setup_xmon_sysrq);
		device_initcall(setup_xmon_sysrq);
		#endif /* CONFIG_MAGIC_SYSRQ */

		static int __initdata xmon_early;
		static int xmon_early __initdata;

		static int __init early_parse_xmon(char *p)
		{
		@@ -3335,8 +3330,6 @@ static int __init early_parse_xmon(char *p)
		xmon_on = 1;
		} else if (strncmp(p, "off", 3) == 0)
		xmon_on = 0;
		else if (strncmp(p, "nobt", 4) == 0)
		xmon_no_auto_backtrace = 1;
		else
		return 1;

Admin message