Input: feed more data into entropy pool (b55eb298) · Commits · 戴 / test

Commit ("Input: Send events one packet at a time") significantly reduced amount of entropy input core was feeding to the rest of the system, because only the very first event in the event block would be used as source of entropy. With this change we will be calling add_input_randomness() for every event that is not filtered by the input core as a duplicate. In addition, all EV_SYN events are ignored. Acked-by:

Henrik Rydberg <rydberg@bitmath.org> Acked-by:

Benjamin Tissoires <benjamin.tissoires@redhat.com> Acked-by:

Jiri Kosina <jkosina@suse.cz> Signed-off-by:

Dmitry Torokhov <dmitry.torokhov@gmail.com>

drivers/input/input.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -153,8 +153,6 @@ static void input_pass_values(struct input_dev *dev,

		rcu_read_unlock();

		add_input_randomness(vals->type, vals->code, vals->value);

		/* trigger auto repeat for key events */
		if (test_bit(EV_REP, dev->evbit) && test_bit(EV_KEY, dev->evbit)) {
		for (v = vals; v != vals + count; v++) {
		@@ -371,9 +369,10 @@ static int input_get_disposition(struct input_dev *dev,
		static void input_handle_event(struct input_dev *dev,
		unsigned int type, unsigned int code, int value)
		{
		int disposition;
		int disposition = input_get_disposition(dev, type, code, &value);

		disposition = input_get_disposition(dev, type, code, &value);
		if (disposition != INPUT_IGNORE_EVENT && type != EV_SYN)
		add_input_randomness(type, code, value);

		if ((disposition & INPUT_PASS_TO_DEVICE) && dev->event)
		dev->event(dev, type, code, value);

Admin message