Commit b5540ce1 authored by Adrian Hunter's avatar Adrian Hunter Committed by Ulf Hansson
Browse files

mmc: sdhci: Disable re-tuning for HS400 



Re-tuning for HS400 mode must be done in HS200
mode. Currently there is no support for that.
That needs to be reflected in the code.
Specifically, if tuning is executed in HS400 mode
then return an error, and do not start the
tuning timer if HS200 tuning is being done prior
to switching to HS400.

Note that periodic re-tuning is not expected
to be needed for HS400 but re-tuning is still
needed after the host controller has lost power.
In the case of suspend/resume that is not necessary
because the card is fully re-initialised. That
just leaves runtime suspend/resume with no support
for HS400 re-tuning.

Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 38e40bf5

drivers/mmc/host/sdhci.c

+29 −0
Original line number Diff line number Diff line
@@ -1878,6 +1878,18 @@ static int sdhci_card_busy(struct mmc_host *mmc) 
	return !(present_state & SDHCI_DATA_LVL_MASK);

}



static int sdhci_prepare_hs400_tuning(struct mmc_host *mmc, struct mmc_ios *ios)

{

	struct sdhci_host *host = mmc_priv(mmc);

	unsigned long flags;



	spin_lock_irqsave(&host->lock, flags);

	host->flags |= SDHCI_HS400_TUNING;

	spin_unlock_irqrestore(&host->lock, flags);



	return 0;

}



static int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode)

{

	struct sdhci_host *host = mmc_priv(mmc);
@@ -1886,10 +1898,14 @@ static int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode) 
	int err = 0;

	unsigned long flags;

	unsigned int tuning_count = 0;

	bool hs400_tuning;



	sdhci_runtime_pm_get(host);

	spin_lock_irqsave(&host->lock, flags);



	hs400_tuning = host->flags & SDHCI_HS400_TUNING;

	host->flags &= ~SDHCI_HS400_TUNING;



	if (host->tuning_mode == SDHCI_TUNING_MODE_1)

		tuning_count = host->tuning_count;
@@ -1901,8 +1917,20 @@ static int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode) 
	 * tuning function has to be executed.

	 */

	switch (host->timing) {

	/* HS400 tuning is done in HS200 mode */

	case MMC_TIMING_MMC_HS400:

		err = -EINVAL;

		goto out_unlock;



	case MMC_TIMING_MMC_HS200:

		/*

		 * Periodic re-tuning for HS400 is not expected to be needed, so

		 * disable it here.

		 */

		if (hs400_tuning)

			tuning_count = 0;

		break;



	case MMC_TIMING_UHS_SDR104:

		break;
@@ -2130,6 +2158,7 @@ static const struct mmc_host_ops sdhci_ops = { 
	.hw_reset	= sdhci_hw_reset,

	.enable_sdio_irq = sdhci_enable_sdio_irq,

	.start_signal_voltage_switch	= sdhci_start_signal_voltage_switch,

	.prepare_hs400_tuning		= sdhci_prepare_hs400_tuning,

	.execute_tuning			= sdhci_execute_tuning,

	.card_event			= sdhci_card_event,

	.card_busy	= sdhci_card_busy,

include/linux/mmc/sdhci.h

+1 −0
Original line number Diff line number Diff line
@@ -137,6 +137,7 @@ struct sdhci_host { 
#define SDHCI_SDR104_NEEDS_TUNING (1<<10)	/* SDR104/HS200 needs tuning */

#define SDHCI_USING_RETUNING_TIMER (1<<11)	/* Host is using a retuning timer for the card */

#define SDHCI_USE_64_BIT_DMA	(1<<12)	/* Use 64-bit DMA */

#define SDHCI_HS400_TUNING	(1<<13)	/* Tuning for HS400 */



	unsigned int version;	/* SDHCI spec. version */

CRA Git | Maintained and supported by SUSTech CRA and CCSE