Commit b52dce87 authored Sep 11, 2018 by Finn Thain Committed by Michael Ellerman Oct 08, 2018

macintosh/via-macii: Synchronous bus reset



Make the reset operation synchronous, like the other ADB drivers.
The reset request is static data but callers may not know that.
This way the struct is not in use when the reset method returns.

Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent 2341629e

drivers/macintosh/via-macii.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -331,7 +331,8 @@ static int macii_reset_bus(void)
		return 0;

		/* Command = 0, Address = ignored */
		adb_request(&req, NULL, 0, 1, ADB_BUSRESET);
		adb_request(&req, NULL, ADBREQ_NOSEND, 1, ADB_BUSRESET);
		macii_send_request(&req, 1);

		/* Don't want any more requests during the Global Reset low time. */
		udelay(3000);

Admin message