Commit b52517e4 authored Oct 25, 2019 by Geert Uytterhoeven Committed by Greg Kroah-Hartman Nov 09, 2019

net: caif: Fix debugfs on 64-bit platforms

"ser_device.state" is "unsigned long", i.e. 32-bit or 64-bit, depending
on the platform. Hence casting its address to "u32 *", and calling
debugfs_create_x32() breaks operation on 64-bit platforms.

Fix this by using the new debugfs_create_xul() helper instead.

Fixes: 9b27105b ("net-caif-driver: add CAIF serial driver (ldisc)")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20191025094130.26033-4-geert+renesas@glider.be

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 0628cda3

drivers/net/caif/caif_serial.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -102,8 +102,8 @@ static inline void debugfs_init(struct ser_device ser, struct tty_struct tty)
		debugfs_create_blob("last_rx_msg", 0400, ser->debugfs_tty_dir,
		&ser->rx_blob);

		debugfs_create_x32("ser_state", 0400, ser->debugfs_tty_dir,
		(u32 *)&ser->state);
		debugfs_create_xul("ser_state", 0400, ser->debugfs_tty_dir,
		&ser->state);

		debugfs_create_x8("tty_status", 0400, ser->debugfs_tty_dir,
		&ser->tty_status);