Commit b51f3bee authored by Johannes Berg's avatar Johannes Berg
Browse files

cfg80211: change bandwidth reporting to explicit field 



For some reason, we made the bandwidth separate flags, which
is rather confusing - a single rate cannot have different
bandwidths at the same time.

Change this to no longer be flags but use a separate field
for the bandwidth ('bw') instead.

While at it, add support for 5 and 10 MHz rates - these are
reported as regular legacy rates with their real bitrate,
but tagged as 5/10 now to make it easier to distinguish them.

In the nl80211 API, the flags are preserved, but the code
now can also clearly only set a single one of the flags.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 97d910d0

drivers/net/wireless/ath/ath6kl/cfg80211.c

+2 −1
Original line number Diff line number Diff line
@@ -1827,6 +1827,7 @@ static int ath6kl_get_station(struct wiphy *wiphy, struct net_device *dev, 
		}



		sinfo->txrate.flags |= RATE_INFO_FLAGS_MCS;

		sinfo->txrate.bw = RATE_INFO_BW_20;

	} else if (is_rate_ht40(rate, &mcs, &sgi)) {

		if (sgi) {

			sinfo->txrate.flags |= RATE_INFO_FLAGS_SHORT_GI;
@@ -1835,7 +1836,7 @@ static int ath6kl_get_station(struct wiphy *wiphy, struct net_device *dev, 
			sinfo->txrate.mcs = mcs;

		}



		sinfo->txrate.flags |= RATE_INFO_FLAGS_40_MHZ_WIDTH;

		sinfo->txrate.bw = RATE_INFO_BW_40;

		sinfo->txrate.flags |= RATE_INFO_FLAGS_MCS;

	} else {

		ath6kl_dbg(ATH6KL_DBG_WLAN_CFG,

drivers/net/wireless/mwifiex/cfg80211.c

+6 −5
Original line number Diff line number Diff line
@@ -856,16 +856,16 @@ mwifiex_parse_htinfo(struct mwifiex_private *priv, u8 tx_htinfo, 
			/* HT or VHT */

			switch (tx_htinfo & (BIT(3) | BIT(2))) {

			case 0:

				/* This will be 20MHz */

				rate->bw = RATE_INFO_BW_20;

				break;

			case (BIT(2)):

				rate->flags |= RATE_INFO_FLAGS_40_MHZ_WIDTH;

				rate->bw = RATE_INFO_BW_40;

				break;

			case (BIT(3)):

				rate->flags |= RATE_INFO_FLAGS_80_MHZ_WIDTH;

				rate->bw = RATE_INFO_BW_80;

				break;

			case (BIT(3) | BIT(2)):

				rate->flags |= RATE_INFO_FLAGS_160_MHZ_WIDTH;

				rate->bw = RATE_INFO_BW_160;

				break;

			}
@@ -885,8 +885,9 @@ mwifiex_parse_htinfo(struct mwifiex_private *priv, u8 tx_htinfo, 
		if ((tx_htinfo & BIT(0)) && (priv->tx_rate < 16)) {

			rate->mcs = priv->tx_rate;

			rate->flags |= RATE_INFO_FLAGS_MCS;

			rate->bw = RATE_INFO_BW_20;

			if (tx_htinfo & BIT(1))

				rate->flags |= RATE_INFO_FLAGS_40_MHZ_WIDTH;

				rate->bw = RATE_INFO_BW_40;

			if (tx_htinfo & BIT(2))

				rate->flags |= RATE_INFO_FLAGS_SHORT_GI;

		}

include/net/cfg80211.h

+25 −8
Original line number Diff line number Diff line
@@ -873,20 +873,35 @@ int cfg80211_check_station_change(struct wiphy *wiphy, 
 *

 * @RATE_INFO_FLAGS_MCS: mcs field filled with HT MCS

 * @RATE_INFO_FLAGS_VHT_MCS: mcs field filled with VHT MCS

 * @RATE_INFO_FLAGS_40_MHZ_WIDTH: 40 MHz width transmission

 * @RATE_INFO_FLAGS_80_MHZ_WIDTH: 80 MHz width transmission

 * @RATE_INFO_FLAGS_160_MHZ_WIDTH: 160 MHz width transmission

 * @RATE_INFO_FLAGS_SHORT_GI: 400ns guard interval

 * @RATE_INFO_FLAGS_60G: 60GHz MCS

 */

enum rate_info_flags {

	RATE_INFO_FLAGS_MCS			= BIT(0),

	RATE_INFO_FLAGS_VHT_MCS			= BIT(1),

	RATE_INFO_FLAGS_40_MHZ_WIDTH		= BIT(2),

	RATE_INFO_FLAGS_80_MHZ_WIDTH		= BIT(3),

	RATE_INFO_FLAGS_160_MHZ_WIDTH		= BIT(4),

	RATE_INFO_FLAGS_SHORT_GI		= BIT(5),

	RATE_INFO_FLAGS_60G			= BIT(6),

	RATE_INFO_FLAGS_SHORT_GI		= BIT(2),

	RATE_INFO_FLAGS_60G			= BIT(3),

};



/**

 * enum rate_info_bw - rate bandwidth information

 *

 * Used by the driver to indicate the rate bandwidth.

 *

 * @RATE_INFO_BW_5: 5 MHz bandwidth

 * @RATE_INFO_BW_10: 10 MHz bandwidth

 * @RATE_INFO_BW_20: 20 MHz bandwidth

 * @RATE_INFO_BW_40: 40 MHz bandwidth

 * @RATE_INFO_BW_80: 80 MHz bandwidth

 * @RATE_INFO_BW_160: 160 MHz bandwidth

 */

enum rate_info_bw {

	RATE_INFO_BW_5,

	RATE_INFO_BW_10,

	RATE_INFO_BW_20,

	RATE_INFO_BW_40,

	RATE_INFO_BW_80,

	RATE_INFO_BW_160,

};



/**
@@ -898,12 +913,14 @@ enum rate_info_flags { 
 * @mcs: mcs index if struct describes a 802.11n bitrate

 * @legacy: bitrate in 100kbit/s for 802.11abg

 * @nss: number of streams (VHT only)

 * @bw: bandwidth (from &enum rate_info_bw)

 */

struct rate_info {

	u8 flags;

	u8 mcs;

	u16 legacy;

	u8 nss;

	u8 bw;

};



/**

include/uapi/linux/nl80211.h

+8 −0
Original line number Diff line number Diff line
@@ -2281,6 +2281,12 @@ struct nl80211_sta_flag_update { 
 * @NL80211_RATE_INFO_80P80_MHZ_WIDTH: unused - 80+80 is treated the

 *	same as 160 for purposes of the bitrates

 * @NL80211_RATE_INFO_160_MHZ_WIDTH: 160 MHz VHT rate

 * @NL80211_RATE_INFO_10_MHZ_WIDTH: 10 MHz width - note that this is

 *	a legacy rate and will be reported as the actual bitrate, i.e.

 *	half the base (20 MHz) rate

 * @NL80211_RATE_INFO_5_MHZ_WIDTH: 5 MHz width - note that this is

 *	a legacy rate and will be reported as the actual bitrate, i.e.

 *	a quarter of the base (20 MHz) rate

 * @__NL80211_RATE_INFO_AFTER_LAST: internal use

 */

enum nl80211_rate_info {
@@ -2295,6 +2301,8 @@ enum nl80211_rate_info { 
	NL80211_RATE_INFO_80_MHZ_WIDTH,

	NL80211_RATE_INFO_80P80_MHZ_WIDTH,

	NL80211_RATE_INFO_160_MHZ_WIDTH,

	NL80211_RATE_INFO_10_MHZ_WIDTH,

	NL80211_RATE_INFO_5_MHZ_WIDTH,



	/* keep last */

	__NL80211_RATE_INFO_AFTER_LAST,

net/mac80211/cfg.c

+20 −11
Original line number Diff line number Diff line
@@ -428,11 +428,13 @@ void sta_set_rate_info_tx(struct sta_info *sta, 
		rinfo->legacy = DIV_ROUND_UP(brate, 1 << shift);

	}

	if (rate->flags & IEEE80211_TX_RC_40_MHZ_WIDTH)

		rinfo->flags |= RATE_INFO_FLAGS_40_MHZ_WIDTH;

	if (rate->flags & IEEE80211_TX_RC_80_MHZ_WIDTH)

		rinfo->flags |= RATE_INFO_FLAGS_80_MHZ_WIDTH;

	if (rate->flags & IEEE80211_TX_RC_160_MHZ_WIDTH)

		rinfo->flags |= RATE_INFO_FLAGS_160_MHZ_WIDTH;

		rinfo->bw = RATE_INFO_BW_40;

	else if (rate->flags & IEEE80211_TX_RC_80_MHZ_WIDTH)

		rinfo->bw = RATE_INFO_BW_80;

	else if (rate->flags & IEEE80211_TX_RC_160_MHZ_WIDTH)

		rinfo->bw = RATE_INFO_BW_160;

	else

		rinfo->bw = RATE_INFO_BW_20;

	if (rate->flags & IEEE80211_TX_RC_SHORT_GI)

		rinfo->flags |= RATE_INFO_FLAGS_SHORT_GI;

}
@@ -459,14 +461,21 @@ void sta_set_rate_info_rx(struct sta_info *sta, struct rate_info *rinfo) 
		rinfo->legacy = DIV_ROUND_UP(brate, 1 << shift);

	}



	if (sta->last_rx_rate_flag & RX_FLAG_40MHZ)

		rinfo->flags |= RATE_INFO_FLAGS_40_MHZ_WIDTH;

	if (sta->last_rx_rate_flag & RX_FLAG_SHORT_GI)

		rinfo->flags |= RATE_INFO_FLAGS_SHORT_GI;

	if (sta->last_rx_rate_vht_flag & RX_VHT_FLAG_80MHZ)

		rinfo->flags |= RATE_INFO_FLAGS_80_MHZ_WIDTH;

	if (sta->last_rx_rate_vht_flag & RX_VHT_FLAG_160MHZ)

		rinfo->flags |= RATE_INFO_FLAGS_160_MHZ_WIDTH;



	if (sta->last_rx_rate_flag & RX_FLAG_5MHZ)

		rinfo->bw = RATE_INFO_BW_5;

	else if (sta->last_rx_rate_flag & RX_FLAG_10MHZ)

		rinfo->bw = RATE_INFO_BW_10;

	else if (sta->last_rx_rate_flag & RX_FLAG_40MHZ)

		rinfo->bw = RATE_INFO_BW_40;

	else if (sta->last_rx_rate_vht_flag & RX_VHT_FLAG_80MHZ)

		rinfo->bw = RATE_INFO_BW_80;

	else if (sta->last_rx_rate_vht_flag & RX_VHT_FLAG_160MHZ)

		rinfo->bw = RATE_INFO_BW_160;

	else

		rinfo->bw = RATE_INFO_BW_20;

}



static int ieee80211_dump_station(struct wiphy *wiphy, struct net_device *dev,

CRA Git | Maintained and supported by SUSTech CRA and CCSE