Commit b4fcd6be authored Apr 15, 2013 by Wang Shilong Committed by Josef Bacik May 06, 2013

Btrfs: fix confusing edquot happening case



Step to reproduce:
	mkfs.btrfs <disk>
	mount <disk> <mnt>
	dd if=/dev/zero of=/<mnt>/data bs=1M count=10
	sync
	btrfs quota enable <mnt>
	btrfs qgroup create 0/5 <mnt>
	btrfs qgroup limit 5M 0/5 <mnt>
	rm -f /<mnt>/data
	sync
	btrfs qgroup show <mnt>
	dd if=/dev/zero of=data bs=1M count=1

>From the perspective of users, qgroup's referenced or exclusive
is negative,but user can not continue to write data! a workaround
way is to cast u64 to s64 when doing qgroup reservation.

Signed-off-by: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
Reviewed-by: Arne Jansen <sensille@gmx.net>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>

parent e36902d4

fs/btrfs/qgroup.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1616,14 +1616,14 @@ int btrfs_qgroup_reserve(struct btrfs_root *root, u64 num_bytes)
		qg = (struct btrfs_qgroup *)(uintptr_t)unode->aux;

		if ((qg->lim_flags & BTRFS_QGROUP_LIMIT_MAX_RFER) &&
		qg->reserved + qg->rfer + num_bytes >
		qg->reserved + (s64)qg->rfer + num_bytes >
		qg->max_rfer) {
		ret = -EDQUOT;
		goto out;
		}

		if ((qg->lim_flags & BTRFS_QGROUP_LIMIT_MAX_EXCL) &&
		qg->reserved + qg->excl + num_bytes >
		qg->reserved + (s64)qg->excl + num_bytes >
		qg->max_excl) {
		ret = -EDQUOT;
		goto out;

Admin message