Commit b4c458b3 authored Jun 29, 2009 by Csaba Henk Committed by Miklos Szeredi Jun 30, 2009

fuse: fix return value of fuse_dev_write()



On 64 bit systems -- where sizeof(ssize_t) > sizeof(int) -- the following test
exposes a bug due to a non-careful return of an int or unsigned value:

implement a FUSE filesystem which sends an unsolicited notification to
the kernel with invalid opcode. The respective write to /dev/fuse
will return (1 << 32) - EINVAL with errno == 0 instead of -1 with
errno == EINVAL.

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
CC: stable@kernel.org

parent 28d0325c

fs/fuse/dev.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -910,7 +910,7 @@ static ssize_t fuse_dev_write(struct kiocb iocb, const struct iovec iov,
		unsigned long nr_segs, loff_t pos)
		{
		int err;
		unsigned nbytes = iov_length(iov, nr_segs);
		size_t nbytes = iov_length(iov, nr_segs);
		struct fuse_req *req;
		struct fuse_out_header oh;
		struct fuse_copy_state cs;

Admin message