Commit b4c2951a authored Dec 02, 2017 by Oliver Hartkopp Committed by Marc Kleine-Budde Jan 04, 2018

can: vxcan: improve handling of missing peer name attribute



Picking up the patch from Serhey Popovych (commit 191cdb38,
"veth: Be more robust on network device creation when no attributes").

When the peer name attribute is not provided the former implementation tries
to register the given device name twice ... which leads to -EEXIST.
If only one device name is given apply an automatic generated and valid name
for the peer.

Cc: Serhey Popovych <serhe.popovych@gmail.com>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent 820d1d5e

drivers/net/can/vxcan.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -194,7 +194,7 @@ static int vxcan_newlink(struct net net, struct net_device dev,
		tbp = peer_tb;
		}

		if (tbp[IFLA_IFNAME]) {
		if (ifmp && tbp[IFLA_IFNAME]) {
		nla_strlcpy(ifname, tbp[IFLA_IFNAME], IFNAMSIZ);
		name_assign_type = NET_NAME_USER;
		} else {

Admin message