ARM: dts: s5pv210: Fix camera clock provider on Goni board (b4bcbdee) · Commits · 戴 / test

The camera driver (according also to bindings) registers a clock provider if clock-output-names property is present and later the sensors use registered clocks. The DTS for S5Pv210 Goni board was incorrectly adding a child node with clock output cells but without clock-output-names property. Although the DTS was compiling (with "/soc/camera/clock-controller: missing or empty reg/ranges property" warning), the clock provider was not registered. Signed-off-by:

Krzysztof Kozlowski <krzk@kernel.org>

arch/arm/boot/dts/s5pv210-goni.dts

+1 −1

Original line number	Diff line number	Diff line
		@@ -376,7 +376,7 @@
		vdd_core-supply = <&ldo14_reg>;

		clock-frequency = <16000000>;
		clocks = <&clock_cam 0>;
		clocks = <&camera 0>;
		clock-names = "mclk";
		nreset-gpios = <&gpb 2 0>;
		nstby-gpios = <&gpb 0 0>;

arch/arm/boot/dts/s5pv210.dtsi

+2 −4

Original line number	Diff line number	Diff line
		@@ -585,11 +585,9 @@
		clock-names = "sclk_cam0", "sclk_cam1";
		#address-cells = <1>;
		#size-cells = <1>;
		ranges;

		clock_cam: clock-controller {
		#clock-cells = <1>;
		};
		clock-output-names = "cam_a_clkout", "cam_b_clkout";
		ranges;

		csis0: csis@fa600000 {
		compatible = "samsung,s5pv210-csis";

Admin message