Commit b4b1b7ed authored Apr 20, 2016 by Axel Haslam Committed by Greg Kroah-Hartman Apr 21, 2016

greybus: uart: Update line coding settings only when needed



The check for line coding changed should use memcmp and not memcpy.

Testing done: trivial

Reviewed-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Axel Haslam <ahaslam@baylibre.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>

parent 41d51402

drivers/staging/greybus/uart.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -383,7 +383,7 @@ static void gb_tty_set_termios(struct tty_struct *tty,
		send_control(gb_tty, newctrl);
		}

		if (memcpy(&gb_tty->line_coding, &newline, sizeof(newline))) {
		if (memcmp(&gb_tty->line_coding, &newline, sizeof(newline))) {
		memcpy(&gb_tty->line_coding, &newline, sizeof(newline));
		send_line_coding(gb_tty);
		}

Admin message