Commit b4681c28 authored Dec 20, 2017 by Ido Schimmel Committed by David S. Miller Dec 20, 2017

ipv4: Fix use-after-free when flushing FIB tables



Since commit 0ddcf43d ("ipv4: FIB Local/MAIN table collapse") the
local table uses the same trie allocated for the main table when custom
rules are not in use.

When a net namespace is dismantled, the main table is flushed and freed
(via an RCU callback) before the local table. In case the callback is
invoked before the local table is iterated, a use-after-free can occur.

Fix this by iterating over the FIB tables in reverse order, so that the
main table is always freed after the local table.

v3: Reworded comment according to Alex's suggestion.
v2: Add a comment to make the fix more explicit per Dave's and Alex's
feedback.

Fixes: 0ddcf43d ("ipv4: FIB Local/MAIN table collapse")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Acked-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ad3cbf61

net/ipv4/fib_frontend.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -1298,14 +1298,19 @@ err_table_hash_alloc:

		static void ip_fib_net_exit(struct net *net)
		{
		unsigned int i;
		int i;

		rtnl_lock();
		#ifdef CONFIG_IP_MULTIPLE_TABLES
		RCU_INIT_POINTER(net->ipv4.fib_main, NULL);
		RCU_INIT_POINTER(net->ipv4.fib_default, NULL);
		#endif
		for (i = 0; i < FIB_TABLE_HASHSZ; i++) {
		/* Destroy the tables in reverse order to guarantee that the
		* local table, ID 255, is destroyed before the main table, ID
		* 254. This is necessary as the local table may contain
		* references to data contained in the main table.
		*/
		for (i = FIB_TABLE_HASHSZ - 1; i >= 0; i--) {
		struct hlist_head *head = &net->ipv4.fib_table_hash[i];
		struct hlist_node *tmp;
		struct fib_table *tb;

Admin message