Commit b455dc35 authored Nov 25, 2019 by Jorge Ramirez-Ortiz Committed by Stephen Boyd Dec 18, 2019

clk: qcom: hfpll: CLK_IGNORE_UNUSED



When COMMON_CLK_DISABLED_UNUSED is set, in an effort to save power and
to keep the software model of the clock in line with reality, the
framework transverses the clock tree and disables those clocks that
were enabled by the firmware but have not been enabled by any device
driver.

If CPUFREQ is enabled, early during the system boot, it might attempt
to change the CPU frequency ("set_rate"). If the HFPLL is selected as
a provider, it will then change the rate for this clock.

As boot continues, clk_disable_unused_subtree will run. Since it wont
find a valid counter (enable_count) for a clock that is actually
enabled it will attempt to disable it which will cause the CPU to
stop. Notice that in this driver, calls to check whether the clock is
enabled are routed via the is_enabled callback which queries the
hardware.

The following commit, rather than marking the clock critical and
forcing the clock to be always enabled, addresses the above scenario
making sure the clock is not disabled but it continues to rely on the
firmware to enable the clock.

Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lkml.kernel.org/r/20191125135910.679310-5-niklas.cassel@linaro.org


Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent 9e406674

drivers/clk/qcom/hfpll.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -56,6 +56,13 @@ static int qcom_hfpll_probe(struct platform_device *pdev)
		.parent_names = (const char *[]){ "xo" },
		.num_parents = 1,
		.ops = &clk_ops_hfpll,
		/*
		* rather than marking the clock critical and forcing the clock
		* to be always enabled, we make sure that the clock is not
		* disabled: the firmware remains responsible of enabling this
		* clock (for more info check the commit log)
		*/
		.flags = CLK_IGNORE_UNUSED,
		};
		int ret;

Admin message