Commit b44980f8 authored by Sebastian Sanchez's avatar Sebastian Sanchez Committed by Doug Ledford
Browse files

IB/hfi1: Replace qp->refcount release code with standard driver wrapper 



Some parts of the code don't use the standard release
wrapper rvt_put_qp() for decrementing and testing
the refcount to then try to use a resource.
Replace this code with the standard driver wrapper.

Fixes: Commit 4d6f85c3 ("IB/rdmavt, IB/qib, IB/hfi1: Use new QP put get routines")
Reviewed-by: default avatarMike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: default avatarSebastian Sanchez <sebastian.sanchez@intel.com>
Signed-off-by: default avatarDennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 00801674

drivers/infiniband/hw/hfi1/driver.c

+1 −2
Original line number Diff line number Diff line
@@ -793,8 +793,7 @@ static inline void process_rcv_qp_work(struct hfi1_packet *packet) 
				hfi1_schedule_send(qp);

			spin_unlock_irqrestore(&qp->s_lock, flags);

		}

		if (atomic_dec_and_test(&qp->refcount))

			wake_up(&qp->wait);

		rvt_put_qp(qp);

	}

}

drivers/infiniband/sw/rdmavt/mcast.c

+2 −3
Original line number Diff line number Diff line
@@ -81,7 +81,7 @@ static struct rvt_mcast_qp *rvt_mcast_qp_alloc(struct rvt_qp *qp) 
		goto bail;



	mqp->qp = qp;

	atomic_inc(&qp->refcount);

	rvt_get_qp(qp);



bail:

	return mqp;
@@ -92,8 +92,7 @@ static void rvt_mcast_qp_free(struct rvt_mcast_qp *mqp) 
	struct rvt_qp *qp = mqp->qp;



	/* Notify hfi1_destroy_qp() if it is waiting. */

	if (atomic_dec_and_test(&qp->refcount))

		wake_up(&qp->wait);

	rvt_put_qp(qp);



	kfree(mqp);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE