Commit b43e36d7 authored by Dan Carpenter's avatar Dan Carpenter Committed by Kalle Valo
Browse files

mt76: Off by one in mt76_calc_rx_airtime()



The sband->bitrates[] array has "sband->n_bitrates" elements so this
check needs to be >= instead of > or we could read beyond the end of the
array.

These values come from when we call mt76_register_device():

	ret = mt76_register_device(&dev->mt76, true, mt7603_rates,
				   ARRAY_SIZE(mt7603_rates));

Here sband->bitrates[] is mt7603_rates[] and ->n_bitrates is the
ARRAY_SIZE()

Fixes: 5ce09c1a ("mt76: track rx airtime for airtime fairness and survey")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent d68f4e43
Loading
Loading
Loading
Loading
+1 −1
Original line number Original line Diff line number Diff line
@@ -242,7 +242,7 @@ u32 mt76_calc_rx_airtime(struct mt76_dev *dev, struct mt76_rx_status *status,
			return 0;
			return 0;


		sband = dev->hw->wiphy->bands[status->band];
		sband = dev->hw->wiphy->bands[status->band];
		if (!sband || status->rate_idx > sband->n_bitrates)
		if (!sband || status->rate_idx >= sband->n_bitrates)
			return 0;
			return 0;


		rate = &sband->bitrates[status->rate_idx];
		rate = &sband->bitrates[status->rate_idx];