Commit b42fe98c authored Dec 02, 2020 by Qu Wenruo Committed by David Sterba Dec 09, 2020

btrfs: scrub: allow scrub to work with subpage sectorsize



Since btrfs scrub is utilizing its own infrastructure to submit
read/write, scrub is independent from all other routines.

This brings one very neat feature, allow us to read 4K data into offset
0 of a 64K page.  So is the writeback routine.

This makes scrub on subpage sector size much easier to implement, and
thanks to previous commits which just changed the implementation to
always do scrub based on sector size, now scrub can handle subpage
filesystem without any problem.

This patch will just remove the restriction on
(sectorsize != PAGE_SIZE), to make scrub finally work on subpage
filesystems.

Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent b29dca44

fs/btrfs/scrub.c

+0 −8

Original line number	Diff line number	Diff line
		@@ -3885,14 +3885,6 @@ int btrfs_scrub_dev(struct btrfs_fs_info *fs_info, u64 devid, u64 start,
		return -EINVAL;
		}

		if (fs_info->sectorsize != PAGE_SIZE) {
		/* not supported for data w/o checksums */
		btrfs_err_rl(fs_info,
		"scrub: size assumption sectorsize != PAGE_SIZE (%d != %lu) fails",
		fs_info->sectorsize, PAGE_SIZE);
		return -EINVAL;
		}

		if (fs_info->nodesize >
		PAGE_SIZE * SCRUB_MAX_PAGES_PER_BLOCK \|\|
		fs_info->sectorsize > PAGE_SIZE * SCRUB_MAX_PAGES_PER_BLOCK) {

Admin message