Commit b40977d9 authored by Mike Christie's avatar Mike Christie Committed by James Bottomley
Browse files

[SCSI] iser: fix handling of scsi cmnds during recovery. 



After the stop_conn callback has returned the LLD should not
touch the scsi cmds. iscsi_tcp and libiscsi use the
conn->recv_lock and suspend_rx field to halt recv path
processing, but iser does not have any protection.

This patch modifies iser so that userspace can just
call the ep_disconnect callback, which will halt
all recv IO, before calling the stop_conn callback so
we do not have to worry about the conn->recv_lock and
suspend rx field. iser just needs to stop the send side
from accessing the ib conn.

Fixup to handle when the ep poll fails and ep disconnect
is called from Erez.

Signed-off-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent 5af3e91d

drivers/infiniband/ulp/iser/iscsi_iser.c

+39 −3
Original line number Diff line number Diff line
@@ -305,10 +305,18 @@ iscsi_iser_conn_destroy(struct iscsi_cls_conn *cls_conn) 
{

	struct iscsi_conn *conn = cls_conn->dd_data;

	struct iscsi_iser_conn *iser_conn = conn->dd_data;

	struct iser_conn *ib_conn = iser_conn->ib_conn;



	if (iser_conn->ib_conn)

		iser_conn->ib_conn->iser_conn = NULL;

	iscsi_conn_teardown(cls_conn);

	/*

	 * Userspace will normally call the stop callback and

	 * already have freed the ib_conn, but if it goofed up then

	 * we free it here.

	 */

	if (ib_conn) {

		ib_conn->iser_conn = NULL;

		iser_conn_put(ib_conn);

	}

}



static int
@@ -340,12 +348,29 @@ iscsi_iser_conn_bind(struct iscsi_cls_session *cls_session, 
	iser_conn = conn->dd_data;

	ib_conn->iser_conn = iser_conn;

	iser_conn->ib_conn  = ib_conn;

	iser_conn_get(ib_conn);



	conn->recv_lock = &iser_conn->lock;



	return 0;

}



static void

iscsi_iser_conn_stop(struct iscsi_cls_conn *cls_conn, int flag)

{

	struct iscsi_conn *conn = cls_conn->dd_data;

	struct iscsi_iser_conn *iser_conn = conn->dd_data;

	struct iser_conn *ib_conn = iser_conn->ib_conn;



	iscsi_conn_stop(cls_conn, flag);

	/*

	 * There is no unbind event so the stop callback

	 * must release the ref from the bind.

	 */

	iser_conn_put(ib_conn);

	iser_conn->ib_conn = NULL;

}



static int

iscsi_iser_conn_start(struct iscsi_cls_conn *cls_conn)

{
@@ -564,6 +589,17 @@ iscsi_iser_ep_disconnect(__u64 ep_handle) 
	if (!ib_conn)

		return;



	if (ib_conn->iser_conn)

		/*

		 * Must suspend xmit path if the ep is bound to the

		 * iscsi_conn, so we know we are not accessing the ib_conn

		 * when we free it.

		 *

		 * This may not be bound if the ep poll failed.

		 */

		iscsi_suspend_tx(ib_conn->iser_conn->iscsi_conn);





	iser_err("ib conn %p state %d\n",ib_conn, ib_conn->state);

	iser_conn_terminate(ib_conn);

}
@@ -622,7 +658,7 @@ static struct iscsi_transport iscsi_iser_transport = { 
	.get_conn_param		= iscsi_conn_get_param,

	.get_session_param	= iscsi_session_get_param,

	.start_conn             = iscsi_iser_conn_start,

	.stop_conn              = iscsi_conn_stop,

	.stop_conn              = iscsi_iser_conn_stop,

	/* iscsi host params */

	.get_host_param		= iscsi_host_get_param,

	.set_host_param		= iscsi_host_set_param,

drivers/infiniband/ulp/iser/iscsi_iser.h

+5 −0
Original line number Diff line number Diff line
@@ -242,6 +242,7 @@ struct iser_device { 
struct iser_conn {

	struct iscsi_iser_conn       *iser_conn; /* iser conn for upcalls  */

	enum iser_ib_conn_state	     state;	    /* rdma connection state   */

	atomic_t		     refcount;

	spinlock_t		     lock;	    /* used for state changes  */

	struct iser_device           *device;       /* device context          */

	struct rdma_cm_id            *cma_id;       /* CMA ID		       */
@@ -314,6 +315,10 @@ void iscsi_iser_recv(struct iscsi_conn *conn, 


int  iser_conn_init(struct iser_conn **ib_conn);



void iser_conn_get(struct iser_conn *ib_conn);



void iser_conn_put(struct iser_conn *ib_conn);



void iser_conn_terminate(struct iser_conn *ib_conn);



void iser_rcv_completion(struct iser_desc *desc,

drivers/infiniband/ulp/iser/iser_verbs.c

+13 −1
Original line number Diff line number Diff line
@@ -328,6 +328,17 @@ static void iser_conn_release(struct iser_conn *ib_conn) 
	kfree(ib_conn);

}



void iser_conn_get(struct iser_conn *ib_conn)

{

	atomic_inc(&ib_conn->refcount);

}



void iser_conn_put(struct iser_conn *ib_conn)

{

	if (atomic_dec_and_test(&ib_conn->refcount))

		iser_conn_release(ib_conn);

}



/**

 * triggers start of the disconnect procedures and wait for them to be done

 */
@@ -349,7 +360,7 @@ void iser_conn_terminate(struct iser_conn *ib_conn) 
	wait_event_interruptible(ib_conn->wait,

				 ib_conn->state == ISER_CONN_DOWN);



	iser_conn_release(ib_conn);

	iser_conn_put(ib_conn);

}



static void iser_connect_error(struct rdma_cm_id *cma_id)
@@ -496,6 +507,7 @@ int iser_conn_init(struct iser_conn **ibconn) 
	init_waitqueue_head(&ib_conn->wait);

	atomic_set(&ib_conn->post_recv_buf_count, 0);

	atomic_set(&ib_conn->post_send_buf_count, 0);

	atomic_set(&ib_conn->refcount, 1);

	INIT_LIST_HEAD(&ib_conn->conn_list);

	spin_lock_init(&ib_conn->lock);

drivers/scsi/libiscsi.c

+2 −1
Original line number Diff line number Diff line
@@ -1383,11 +1383,12 @@ static void fail_all_commands(struct iscsi_conn *conn, unsigned lun, 
	}

}



static void iscsi_suspend_tx(struct iscsi_conn *conn)

void iscsi_suspend_tx(struct iscsi_conn *conn)

{

	set_bit(ISCSI_SUSPEND_BIT, &conn->suspend_tx);

	scsi_flush_work(conn->session->host);

}

EXPORT_SYMBOL_GPL(iscsi_suspend_tx);



static void iscsi_start_tx(struct iscsi_conn *conn)

{

CRA Git | Maintained and supported by SUSTech CRA and CCSE