Commit b40341fa authored Sep 29, 2020 by Steven Rostedt (VMware)

ftrace: Move RCU is watching check after recursion check

The first thing that the ftrace function callback helper functions should do
is to check for recursion. Peter Zijlstra found that when
"rcu_is_watching()" had its notrace removed, it caused perf function tracing
to crash. This is because the call of rcu_is_watching() is tested before
function recursion is checked and and if it is traced, it will cause an
infinite recursion loop.

rcu_is_watching() should still stay notrace, but to prevent this should
never had crashed in the first place. The recursion prevention must be the
first thing done in callback functions.

Link: https://lore.kernel.org/r/20200929112541.GM2628@hirez.programming.kicks-ass.net



Cc: stable@vger.kernel.org
Cc: Paul McKenney <paulmck@kernel.org>
Fixes: c68c0fa2 ("ftrace: Have ftrace_ops_get_func() handle RCU and PER_CPU flags too")
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reported-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

parent 851e6f61

kernel/trace/ftrace.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -6993,15 +6993,13 @@ static void ftrace_ops_assist_func(unsigned long ip, unsigned long parent_ip,
		{
		int bit;

		if ((op->flags & FTRACE_OPS_FL_RCU) && !rcu_is_watching())
		return;

		bit = trace_test_and_set_recursion(TRACE_LIST_START, TRACE_LIST_MAX);
		if (bit < 0)
		return;

		preempt_disable_notrace();

		if (!(op->flags & FTRACE_OPS_FL_RCU) \|\| rcu_is_watching())
		op->func(ip, parent_ip, op, regs);

		preempt_enable_notrace();

Admin message