Commit b4033c17 authored by Ashok Raj's avatar Ashok Raj Committed by Greg Kroah-Hartman
Browse files

[PATCH] PCI: Change MSI to use physical delivery mode always 



MSI hardcoded delivery mode to use logical delivery mode. Recently
x86_64 moved to use physical mode addressing to support physflat mode.
With this mode enabled noticed that my eth with MSI werent working.

msi_address_init()  was hardcoded to use logical mode for i386 and x86_64.
So when we switch to use physical mode, things stopped working.

Since anyway we dont use lowest priority delivery with MSI, its always
directed to just a single CPU. Its safe  and simpler to use
physical mode always, even when we use logical delivery mode for IPI's
or other ioapic RTE's.

Signed-off-by: default avatarAshok Raj <ashok.raj@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 48b19148

drivers/pci/msi.c

+12 −8
Original line number Diff line number Diff line
@@ -23,6 +23,8 @@ 
#include "pci.h"

#include "msi.h"



#define MSI_TARGET_CPU		first_cpu(cpu_online_map)



static DEFINE_SPINLOCK(msi_lock);

static struct msi_desc* msi_desc[NR_IRQS] = { [0 ... NR_IRQS-1] = NULL };

static kmem_cache_t* msi_cachep;
@@ -92,6 +94,7 @@ static void set_msi_affinity(unsigned int vector, cpumask_t cpu_mask) 
	struct msi_desc *entry;

	struct msg_address address;

	unsigned int irq = vector;

	unsigned int dest_cpu = first_cpu(cpu_mask);



	entry = (struct msi_desc *)msi_desc[vector];

	if (!entry || !entry->dev)
@@ -108,9 +111,9 @@ static void set_msi_affinity(unsigned int vector, cpumask_t cpu_mask) 
		pci_read_config_dword(entry->dev, msi_lower_address_reg(pos),

			&address.lo_address.value);

		address.lo_address.value &= MSI_ADDRESS_DEST_ID_MASK;

		address.lo_address.value |= (cpu_mask_to_apicid(cpu_mask) <<

		address.lo_address.value |= (cpu_physical_id(dest_cpu) <<

									MSI_TARGET_CPU_SHIFT);

		entry->msi_attrib.current_cpu = cpu_mask_to_apicid(cpu_mask);

		entry->msi_attrib.current_cpu = cpu_physical_id(dest_cpu);

		pci_write_config_dword(entry->dev, msi_lower_address_reg(pos),

			address.lo_address.value);

		set_native_irq_info(irq, cpu_mask);
@@ -123,9 +126,9 @@ static void set_msi_affinity(unsigned int vector, cpumask_t cpu_mask) 


		address.lo_address.value = readl(entry->mask_base + offset);

		address.lo_address.value &= MSI_ADDRESS_DEST_ID_MASK;

		address.lo_address.value |= (cpu_mask_to_apicid(cpu_mask) <<

		address.lo_address.value |= (cpu_physical_id(dest_cpu) <<

									MSI_TARGET_CPU_SHIFT);

		entry->msi_attrib.current_cpu = cpu_mask_to_apicid(cpu_mask);

		entry->msi_attrib.current_cpu = cpu_physical_id(dest_cpu);

		writel(address.lo_address.value, entry->mask_base + offset);

		set_native_irq_info(irq, cpu_mask);

		break;
@@ -259,14 +262,15 @@ static void msi_data_init(struct msg_data *msi_data, 
static void msi_address_init(struct msg_address *msi_address)

{

	unsigned int	dest_id;

	unsigned long	dest_phys_id = cpu_physical_id(MSI_TARGET_CPU);



	memset(msi_address, 0, sizeof(struct msg_address));

	msi_address->hi_address = (u32)0;

	dest_id = (MSI_ADDRESS_HEADER << MSI_ADDRESS_HEADER_SHIFT);

	msi_address->lo_address.u.dest_mode = MSI_DEST_MODE;

	msi_address->lo_address.u.dest_mode = MSI_PHYSICAL_MODE;

	msi_address->lo_address.u.redirection_hint = MSI_REDIRECTION_HINT_MODE;

	msi_address->lo_address.u.dest_id = dest_id;

	msi_address->lo_address.value |= (MSI_TARGET_CPU << MSI_TARGET_CPU_SHIFT);

	msi_address->lo_address.value |= (dest_phys_id << MSI_TARGET_CPU_SHIFT);

}



static int msi_free_vector(struct pci_dev* dev, int vector, int reassign);

include/asm-i386/msi.h

+1 −8
Original line number Diff line number Diff line
@@ -10,13 +10,6 @@ 
#include <mach_apic.h>



#define LAST_DEVICE_VECTOR		232

#define MSI_DEST_MODE			MSI_LOGICAL_MODE

#define MSI_TARGET_CPU_SHIFT	12



#ifdef CONFIG_SMP

#define MSI_TARGET_CPU		logical_smp_processor_id()

#else

#define MSI_TARGET_CPU	cpu_to_logical_apicid(first_cpu(cpu_online_map))

#endif



#endif /* ASM_MSI_H */

include/asm-i386/smp.h

+6 −0
Original line number Diff line number Diff line
@@ -45,6 +45,8 @@ extern void unlock_ipi_call_lock(void); 
#define MAX_APICID 256

extern u8 x86_cpu_to_apicid[];



#define cpu_physical_id(cpu)	x86_cpu_to_apicid[cpu]



#ifdef CONFIG_HOTPLUG_CPU

extern void cpu_exit_clear(void);

extern void cpu_uninit(void);
@@ -92,6 +94,10 @@ extern int __cpu_disable(void); 
extern void __cpu_die(unsigned int cpu);

#endif /* !__ASSEMBLY__ */



#else /* CONFIG_SMP */



#define cpu_physical_id(cpu)		boot_cpu_physical_apicid



#define NO_PROC_ID		0xFF		/* No processor magic marker */



#endif

include/asm-ia64/msi.h

+0 −3
Original line number Diff line number Diff line
@@ -12,9 +12,6 @@ 
static inline void set_intr_gate (int nr, void *func) {}

#define IO_APIC_VECTOR(irq)	(irq)

#define ack_APIC_irq		ia64_eoi

#define cpu_mask_to_apicid(mask) cpu_physical_id(first_cpu(mask))

#define MSI_DEST_MODE		MSI_PHYSICAL_MODE

#define MSI_TARGET_CPU	((ia64_getreg(_IA64_REG_CR_LID) >> 16) & 0xffff)

#define MSI_TARGET_CPU_SHIFT	4



#endif /* ASM_MSI_H */

include/asm-x86_64/msi.h

+1 −3
Original line number Diff line number Diff line
@@ -11,8 +11,6 @@ 
#include <asm/smp.h>



#define LAST_DEVICE_VECTOR		232

#define MSI_DEST_MODE			MSI_LOGICAL_MODE

#define MSI_TARGET_CPU_SHIFT	12

#define MSI_TARGET_CPU			logical_smp_processor_id()



#endif /* ASM_MSI_H */

CRA Git | Maintained and supported by SUSTech CRA and CCSE