Commit b3fb36ed authored Apr 16, 2020 by Frank Rowand Committed by Rob Herring Apr 17, 2020

of: unittest: kmemleak on changeset destroy



kmemleak reports several memory leaks from devicetree unittest.
This is the fix for problem 1 of 5.

of_unittest_changeset() reaches deeply into the dynamic devicetree
functions.  Several nodes were left with an elevated reference
count and thus were not properly cleaned up.  Fix the reference
counts so that the memory will be freed.

Fixes: 201c910b ("of: Transactional DT support.")
Reported-by: Erhard F. <erhard_f@mailbox.org>
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
Signed-off-by: Rob Herring <robh@kernel.org>

parent 21a431e6

drivers/of/unittest.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -861,6 +861,10 @@ static void __init of_unittest_changeset(void)
		unittest(!of_changeset_revert(&chgset), "revert failed\n");

		of_changeset_destroy(&chgset);

		of_node_put(n1);
		of_node_put(n2);
		of_node_put(n21);
		#endif
		}

Admin message