thunderx: enable page recycling for non-XDP case (b3e20806) · Commits · 戴 / test

Commit ("net: thunderx: Optimize page recycling for XDP") added code to nicvf_alloc_page() that inadvertently disables receive buffer page recycling for the non-XDP case by always NULL'ng the page pointer. This patch corrects two if-conditionals to allow for the recycling of non-XDP mode pages by only setting the page pointer to NULL when the page is not ready for recycling. Fixes: ("net: thunderx: Optimize page recycling for XDP") Signed-off-by:

Dean Nelson <dnelson@redhat.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/cavium/thunder/nicvf_queues.c

+11 −12

Original line number	Diff line number	Diff line
		@@ -105,21 +105,20 @@ static inline struct pgcache nicvf_alloc_page(struct nicvf nic,
		/* Check if page can be recycled */
		if (page) {
		ref_count = page_ref_count(page);
		/* Check if this page has been used once i.e 'put_page'
		* called after packet transmission i.e internal ref_count
		* and page's ref_count are equal i.e page can be recycled.
		/* This page can be recycled if internal ref_count and page's
		* ref_count are equal, indicating that the page has been used
		* once for packet transmission. For non-XDP mode, internal
		* ref_count is always '1'.
		*/
		if (rbdr->is_xdp && (ref_count == pgcache->ref_count))
		if (rbdr->is_xdp) {
		if (ref_count == pgcache->ref_count)
		pgcache->ref_count--;
		else
		page = NULL;

		/* In non-XDP mode, page's ref_count needs to be '1' for it
		* to be recycled.
		*/
		if (!rbdr->is_xdp && (ref_count != 1))
		} else if (ref_count != 1) {
		page = NULL;
		}
		}

		if (!page) {
		page = alloc_pages(gfp \| __GFP_COMP \| __GFP_NOWARN, 0);

Admin message