Commit b3cde198 authored Nov 18, 2016 by Dan Carpenter Committed by Linus Walleij Nov 22, 2016

pinctrl: sunxi: Testing the wrong variable



Smatch complains that we dereference "map" before testing it for NULL
which is true.  We should be testing "*map" instead.  Also on the error
path, we should free *map and set it to NULL.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 04d02c7a

drivers/pinctrl/sunxi/pinctrl-sunxi.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -398,13 +398,14 @@ static int sunxi_pctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
		* map array
		*/
		map = krealloc(map, i * sizeof(struct pinctrl_map), GFP_KERNEL);
		if (!map)
		if (!*map)
		return -ENOMEM;

		return 0;

		err_free_map:
		kfree(map);
		kfree(*map);
		*map = NULL;
		return ret;
		}

Admin message