Commit b3c17f10 authored by David Hildenbrand's avatar David Hildenbrand Committed by Christian Borntraeger
Browse files

KVM: s390: wake up when the VCPU cpu timer expires 



When the VCPU cpu timer expires, we have to wake up just like when the ckc
triggers. For now, setting up a cpu timer in the guest and going into
enabled wait will never lead to a wakeup. This patch fixes this problem.
Just as for the ckc, we have to take care of waking up too early. We
have to recalculate the sleep time and go back to sleep.

Please note that the timer callback calls kvm_s390_get_cpu_timer() from
interrupt context. As the timer is canceled when leaving handle_wait(),
and we don't do any VCPU cpu timer writes/updates in that function, we can
be sure that we will never try to read the VCPU cpu timer from the same cpu
that is currentyl updating the timer (deadlock).

Reported-by: default avatarSascha Silbe <silbe@linux.vnet.ibm.com>
Tested-by: default avatarSascha Silbe <silbe@linux.vnet.ibm.com>
Signed-off-by: default avatarDavid Hildenbrand <dahi@linux.vnet.ibm.com>
Signed-off-by: default avatarChristian Borntraeger <borntraeger@de.ibm.com>
parent 5ebda316

arch/s390/kvm/interrupt.c

+35 −13
Original line number Diff line number Diff line
@@ -909,9 +909,35 @@ int kvm_cpu_has_pending_timer(struct kvm_vcpu *vcpu) 
	return ckc_irq_pending(vcpu) || cpu_timer_irq_pending(vcpu);

}



static u64 __calculate_sltime(struct kvm_vcpu *vcpu)

{

	u64 now, cputm, sltime = 0;



	if (ckc_interrupts_enabled(vcpu)) {

		now = kvm_s390_get_tod_clock_fast(vcpu->kvm);

		sltime = tod_to_ns(vcpu->arch.sie_block->ckc - now);

		/* already expired or overflow? */

		if (!sltime || vcpu->arch.sie_block->ckc <= now)

			return 0;

		if (cpu_timer_interrupts_enabled(vcpu)) {

			cputm = kvm_s390_get_cpu_timer(vcpu);

			/* already expired? */

			if (cputm >> 63)

				return 0;

			return min(sltime, tod_to_ns(cputm));

		}

	} else if (cpu_timer_interrupts_enabled(vcpu)) {

		sltime = kvm_s390_get_cpu_timer(vcpu);

		/* already expired? */

		if (sltime >> 63)

			return 0;

	}

	return sltime;

}



int kvm_s390_handle_wait(struct kvm_vcpu *vcpu)

{

	u64 now, sltime;

	u64 sltime;



	vcpu->stat.exit_wait_state++;
@@ -924,22 +950,20 @@ int kvm_s390_handle_wait(struct kvm_vcpu *vcpu) 
		return -EOPNOTSUPP; /* disabled wait */

	}



	if (!ckc_interrupts_enabled(vcpu)) {

	if (!ckc_interrupts_enabled(vcpu) &&

	    !cpu_timer_interrupts_enabled(vcpu)) {

		VCPU_EVENT(vcpu, 3, "%s", "enabled wait w/o timer");

		__set_cpu_idle(vcpu);

		goto no_timer;

	}



	now = kvm_s390_get_tod_clock_fast(vcpu->kvm);

	sltime = tod_to_ns(vcpu->arch.sie_block->ckc - now);



	/* underflow */

	if (vcpu->arch.sie_block->ckc < now)

	sltime = __calculate_sltime(vcpu);

	if (!sltime)

		return 0;



	__set_cpu_idle(vcpu);

	hrtimer_start(&vcpu->arch.ckc_timer, ktime_set (0, sltime) , HRTIMER_MODE_REL);

	VCPU_EVENT(vcpu, 4, "enabled wait via clock comparator: %llu ns", sltime);

	VCPU_EVENT(vcpu, 4, "enabled wait: %llu ns", sltime);

no_timer:

	srcu_read_unlock(&vcpu->kvm->srcu, vcpu->srcu_idx);

	kvm_vcpu_block(vcpu);
@@ -966,18 +990,16 @@ void kvm_s390_vcpu_wakeup(struct kvm_vcpu *vcpu) 
enum hrtimer_restart kvm_s390_idle_wakeup(struct hrtimer *timer)

{

	struct kvm_vcpu *vcpu;

	u64 now, sltime;

	u64 sltime;



	vcpu = container_of(timer, struct kvm_vcpu, arch.ckc_timer);

	now = kvm_s390_get_tod_clock_fast(vcpu->kvm);

	sltime = tod_to_ns(vcpu->arch.sie_block->ckc - now);

	sltime = __calculate_sltime(vcpu);



	/*

	 * If the monotonic clock runs faster than the tod clock we might be

	 * woken up too early and have to go back to sleep to avoid deadlocks.

	 */

	if (vcpu->arch.sie_block->ckc > now &&

	    hrtimer_forward_now(timer, ns_to_ktime(sltime)))

	if (sltime && hrtimer_forward_now(timer, ns_to_ktime(sltime)))

		return HRTIMER_RESTART;

	kvm_s390_vcpu_wakeup(vcpu);

	return HRTIMER_NORESTART;

CRA Git | Maintained and supported by SUSTech CRA and CCSE