Commit b3af9468 authored Sep 25, 2009 by Wu Fengguang Committed by Jens Axboe Sep 25, 2009

writeback: don't delay inodes redirtied by a fast dirtier



Debug traces show that in per-bdi writeback, the inode under writeback
almost always get redirtied by a busy dirtier.  We used to call
redirty_tail() in this case, which could delay inode for up to 30s.

This is unacceptable because it now happens so frequently for plain cp/dd,
that the accumulated delays could make writeback of big files very slow.

So let's distinguish between data redirty and metadata only redirty.
The first one is caused by a busy dirtier, while the latter one could
happen in XFS, NFS, etc. when they are doing delalloc or updating isize.

The inode being busy dirtied will now be requeued for next io, while
the inode being redirtied by fs will continue to be delayed to avoid
repeated IO.

CC: Jan Kara <jack@suse.cz>
CC: Theodore Ts'o <tytso@mit.edu>
CC: Dave Chinner <david@fromorbit.com>
CC: Chris Mason <chris.mason@oracle.com>
CC: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>

parent 9ecc2738

fs/fs-writeback.c

+9 −3

Original line number	Diff line number	Diff line
		@@ -474,10 +474,15 @@ writeback_single_inode(struct inode inode, struct writeback_control wbc)
		spin_lock(&inode_lock);
		inode->i_state &= ~I_SYNC;
		if (!(inode->i_state & (I_FREEING \| I_CLEAR))) {
		if (inode->i_state & I_DIRTY) {
		if ((inode->i_state & I_DIRTY_PAGES) && wbc->for_kupdate) {
		/*
		* Someone redirtied the inode while were writing back
		* the pages.
		* More pages get dirtied by a fast dirtier.
		*/
		goto select_queue;
		} else if (inode->i_state & I_DIRTY) {
		/*
		* At least XFS will redirty the inode during the
		* writeback (delalloc) and on io completion (isize).
		*/
		redirty_tail(inode);
		} else if (mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)) {
		@@ -502,6 +507,7 @@ writeback_single_inode(struct inode inode, struct writeback_control wbc)
		* soon as the queue becomes uncongested.
		*/
		inode->i_state \|= I_DIRTY_PAGES;
		select_queue:
		if (wbc->nr_to_write <= 0) {
		/*
		* slice used up: queue for next turn

Admin message