media: atomisp: move a static constant out of a header file (b38f7aae) · Commits · 戴 / test

Gcc reports that input_formatter_alignment is not used: In file included from ./drivers/staging/media/atomisp//pci/hive_isp_css_include/input_formatter.h:34, from drivers/staging/media/atomisp//pci/runtime/debug/src/ia_css_debug.c:55: ./drivers/staging/media/atomisp//pci/hive_isp_css_common/host/input_formatter_local.h:118:27: warning: ‘input_formatter_alignment’ defined but not used [-Wunused-const-variable=] However, it is, but only inside input_formatter.c. So, move it out of the header file. Signed-off-by:

Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_formatter.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -27,6 +27,10 @@
		#include "input_formatter_private.h"
		#endif /* __INLINE_INPUT_FORMATTER__ */

		static const unsigned int input_formatter_alignment[N_INPUT_FORMATTER_ID] = {
		ISP_VEC_ALIGN, ISP_VEC_ALIGN, HIVE_ISP_CTRL_DATA_BYTES
		};

		const hrt_address HIVE_IF_SRST_ADDRESS[N_INPUT_FORMATTER_ID] = {
		INPUT_FORMATTER0_SRST_OFFSET,
		INPUT_FORMATTER1_SRST_OFFSET,

drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_formatter_local.h

+0 −4

Original line number	Diff line number	Diff line
		@@ -115,8 +115,4 @@ struct input_formatter_bin_state_s {
		u32 en_status_update;
		};

		static const unsigned int input_formatter_alignment[N_INPUT_FORMATTER_ID] = {
		ISP_VEC_ALIGN, ISP_VEC_ALIGN, HIVE_ISP_CTRL_DATA_BYTES
		};

		#endif /* __INPUT_FORMATTER_LOCAL_H_INCLUDED__ */

Admin message