perf record: Rename perf.data to perf.data.old if --force/-f is used (b38d3464) · Commits · 戴 / test

Suggested-by:

Steven Rostedt <rostedt@goodmis.org> Signed-off-by:

Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Frédéric Weisbecker <fweisbec@gmail.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Paul Mackerras <paulus@samba.org> LKML-Reference: <1260828571-3613-2-git-send-email-acme@infradead.org> Signed-off-by:

Ingo Molnar <mingo@elte.hu>

tools/perf/builtin-record.c

+13 −4

Original line number	Diff line number	Diff line
		@@ -421,11 +421,20 @@ static int __cmd_record(int argc, const char **argv)
		signal(SIGINT, sig_handler);

		if (!stat(output_name, &st) && st.st_size) {
		if (!force && !append_file) {
		fprintf(stderr, "Error, output file %s exists, use -A to append or -f to overwrite.\n",
		if (!force) {
		if (!append_file) {
		pr_err("Error, output file %s exists, use -A "
		"to append or -f to overwrite.\n",
		output_name);
		exit(-1);
		}
		} else {
		char oldname[PATH_MAX];
		snprintf(oldname, sizeof(oldname), "%s.old",
		output_name);
		unlink(oldname);
		rename(output_name, oldname);
		}
		} else {
		append_file = 0;
		}

Admin message